refactor(bindings): read deployed forwarders over HTTP instead of forking#86
Open
jonaprieto wants to merge 1 commit into
Open
refactor(bindings): read deployed forwarders over HTTP instead of forking#86jonaprieto wants to merge 1 commit into
jonaprieto wants to merge 1 commit into
Conversation
…king The bindings tests spun up a forked anvil node per chain just to read view functions (protocol adapter, logic ref, version). Anvil only reports ready once it has fetched fork state from the RPC; over a slow or rate-limited RPC that exceeds anvil's 10s startup timeout and the test panics with `Timeout`. It also gets slower and more fragile as more chains are added. Read the deployed forwarders with a plain HTTP provider, and deploy the reference forwarder once on a local (non-forked) anvil to obtain the expected version constant. No test forks a chain anymore.
jonaprieto
force-pushed
the
refactor/bindings-tests-http-provider
branch
from
21c6e1b to
6b0a3dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindings tests spun up a forked anvil per chain just to read view functions. Anvil only reports ready after it fetches fork state from the RPC, so a slow or rate-limited RPC blows past anvil's 10s startup timeout and the test panics with
Timeout(and it degrades as chains are added).This reads the deployed forwarders with a plain HTTP provider and deploys the reference forwarder once on a local non-forked anvil to get the expected version constant, so no test forks a chain anymore. Same fix already merged in generic-call-forwarder #26.